Required changes to model extracted from IPP #6

New Issue

kadet · 2020-06-11T15:17:55+02:00

kadet commented

2020-06-11 15:17:55 +02:00

Here I will add all things that I extracted from new IPP form:

export enum InternshipType {
    FreeInternship = "FreeInternship",
    GraduateInternship = "GraduateInternship",
    FreeApprenticeship = "FreeApprenticeship",
    PaidApprenticeship = "PaidApprenticeship",
    ForeignInternship = "ForeignInternship",
    UOP = "UOP",
    UD = "UD",
    UZ = "UZ",
    Other = "Other",
}

program in Internship should be rather list of something like InternshipProgramEntry?

program: InternshipProgramEntry[];

export interface InternshipProgramEntry {
    course: Course;
    description: string;
}

And then it could be exposed in Course DTO like so:

possibleProgramEntries: InternshipProgramEntry[];

Here I will add all things that I extracted from new [IPP] form: ```typescript export enum InternshipType { FreeInternship = "FreeInternship", GraduateInternship = "GraduateInternship", FreeApprenticeship = "FreeApprenticeship", PaidApprenticeship = "PaidApprenticeship", ForeignInternship = "ForeignInternship", UOP = "UOP", UD = "UD", UZ = "UZ", Other = "Other", } ``` `program` in `Internship` should be rather list of something like `InternshipProgramEntry`? ```typescript program: InternshipProgramEntry[]; ``` ```typescript export interface InternshipProgramEntry { course: Course; description: string; } ``` And then it could be exposed in Course DTO like so: ``` possibleProgramEntries: InternshipProgramEntry[]; ``` [IPP]: https://eti.pg.edu.pl/documents/611675/100028367/indywidualny%20program%20praktyk

Zonar commented

2020-07-08 17:19:04 +02:00

Done
67cddc1fea
d234246248

Done https://git.kadet.net/system-praktyk/system-praktyk-api/commit/67cddc1fea38633ea1ca12e1fb0b1b4b99850ed7 https://git.kadet.net/system-praktyk/system-praktyk-api/commit/d234246248298a77e016f0a84f7cc597dc7c0419

Zonar closed this issue

2020-07-08 17:19:28 +02:00

Sign in to join this conversation.

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: system-praktyk/system-praktyk-api#6